dart2js: simplify constant expression generation.

pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

Index: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
diff --git a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
index 7f64f57240087eb3497ec166fc84d133048d6e6a..3572ff417d7d49622697c6f5046a633eea5acfa9 100644
--- a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
+++ b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
@@ -417,9 +417,6 @@ abstract class Emitter {
   /// Returns the JS code for accessing the embedded [global].
   jsAst.Expression generateEmbeddedGlobalAccess(String global);
 
-  /// Returns the JS code for accessing the given [constant].
-  jsAst.Expression constantReference(ConstantValue constant);
-
   /// Returns the JS function representing the given function.
   ///
   /// The function must be invoked and can not be used as closure.
@@ -447,5 +444,8 @@ abstract class Emitter {
   int compareConstants(ConstantValue a, ConstantValue b);
   bool isConstantInlinedOrAlreadyEmitted(ConstantValue constant);
 
+  /// Returns the JS code for accessing the given [constant].
+  jsAst.Expression constantReference(ConstantValue constant);

[floitsch, 2015/02/24 23:08:48]

moved here to live with the other constant-related functions.

I think we should rename this function to "referenceConstant". It either gives a
reference or the inlined constant.

[Johnni Winther, 2015/02/25 11:37:02]

Maybe 'generateConstantReference'.

[floitsch, 2015/02/25 16:35:18]

The thing is, that it doesn't always generate a reference, but frequently just
returns the literal. That's why "referenceConstant" feel better to me. "I'm
referencing a constant. I can get back the value or a way to read it".

[Johnni Winther, 2015/02/26 08:24:50]

I rarely read 'reference' as a verb...

[floitsch, 2015/02/26 13:11:33]

useConstant?

[Johnni Winther, 2015/02/26 15:01:46]

It feels wrong; like registering that we use the constant. I'll prefer
'referenceConstant' then.

+
   void invalidateCaches();
 }