dart2js: simplify constant expression generation.

pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 const USE_NEW_EMITTER = const bool.fromEnvironment("dart2js.use.new.emitter");
 
 /**
  * Generates the code for all used classes in the program. Static fields (even
@@ skipping 399 matching lines @@
   /// Returns the JS function that must be invoked to get the value of the
   /// lazily initialized static.
   jsAst.Expression isolateLazyInitializerAccess(FieldElement element);
 
   /// Returns the closure expression of a static function.
   jsAst.Expression isolateStaticClosureAccess(FunctionElement element);
 
   /// Returns the JS code for accessing the embedded [global].
   jsAst.Expression generateEmbeddedGlobalAccess(String global);
 
-  /// Returns the JS code for accessing the given [constant].
-  jsAst.Expression constantReference(ConstantValue constant);
-
   /// Returns the JS function representing the given function.
   ///
   /// The function must be invoked and can not be used as closure.
   jsAst.Expression staticFunctionAccess(FunctionElement element);
 
   jsAst.Expression staticFieldAccess(FieldElement element);
 
   /// Returns the JS constructor of the given element.
   ///
   /// The returned expression must only be used in a JS `new` expression.
   jsAst.Expression constructorAccess(ClassElement e);
 
   /// Returns the JS prototype of the given class [e].
   jsAst.Expression prototypeAccess(ClassElement e, bool hasBeenInstantiated);
 
   /// Returns the JS constructor of the given interceptor class [e].
   jsAst.Expression interceptorClassAccess(ClassElement e);
 
   /// Returns the JS expression representing the type [e].
   jsAst.Expression typeAccess(Element e);
 
   /// Returns the JS expression representing a function that returns 'null'
   jsAst.Expression generateFunctionThatReturnsNull();
 
   int compareConstants(ConstantValue a, ConstantValue b);
   bool isConstantInlinedOrAlreadyEmitted(ConstantValue constant);
 
+  /// Returns the JS code for accessing the given [constant].
+  jsAst.Expression constantReference(ConstantValue constant);

[floitsch, 2015/02/24 23:08:48]

moved here to live with the other constant-related functions.

I think we should rename this function to "referenceConstant". It either gives a
reference or the inlined constant.

[Johnni Winther, 2015/02/25 11:37:02]

Maybe 'generateConstantReference'.

[floitsch, 2015/02/25 16:35:18]

The thing is, that it doesn't always generate a reference, but frequently just
returns the literal. That's why "referenceConstant" feel better to me. "I'm
referencing a constant. I can get back the value or a way to read it".

[Johnni Winther, 2015/02/26 08:24:50]

I rarely read 'reference' as a verb...

[floitsch, 2015/02/26 13:11:33]

useConstant?

[Johnni Winther, 2015/02/26 15:01:46]

It feels wrong; like registering that we use the constant. I'll prefer
'referenceConstant' then.

+
   void invalidateCaches();
 }