Issue 947303003: Fix subtle bugs in sky-scrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 947303003: Fix subtle bugs in sky-scrollable (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix subtle bugs in sky-scrollable Previously the scrollbar wasn't constrained to the scrollable element and we had messed up the math on the fling curve. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c9b95ae81abcb4d298afa268b608498df9418538

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	sky/framework/fling-curve.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/framework/sky-drawer.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/framework/sky-scrollable.sky	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/viewer/converters/input_event_types.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

abarth-chromium

5 years, 10 months ago (2015-02-23 22:20:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c9b95ae81abcb4d298afa268b608498df9418538 (presubmit successful).