Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: sky/viewer/converters/input_event_types.cc

Issue 947303003: Fix subtle bugs in sky-scrollable (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/framework/sky-scrollable.sky ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/converters/input_event_types.cc
diff --git a/sky/viewer/converters/input_event_types.cc b/sky/viewer/converters/input_event_types.cc
index d5bb31ed90eb15955cf17749fb99c48790871a6c..3aa297d4902b88a5da238456ce3a45059fa5cfba 100644
--- a/sky/viewer/converters/input_event_types.cc
+++ b/sky/viewer/converters/input_event_types.cc
@@ -108,10 +108,10 @@ scoped_ptr<blink::WebInputEvent> BuildWebGestureEvent(
break;
case mojo::EVENT_TYPE_SCROLL_FLING_START:
web_event->type = blink::WebInputEvent::GestureFlingStart;
- // TODO(abarth): Why don't we need to divide by the device_pixel_ratio
- // here? For some reason, this seems to get the right velocity.
- web_event->data.flingStart.velocityX = event->gesture_data->velocity_x;
- web_event->data.flingStart.velocityY = event->gesture_data->velocity_y;
+ web_event->data.flingStart.velocityX =
+ event->gesture_data->velocity_x / device_pixel_ratio;
+ web_event->data.flingStart.velocityY =
+ event->gesture_data->velocity_y / device_pixel_ratio;
break;
case mojo::EVENT_TYPE_SCROLL_FLING_CANCEL:
web_event->type = blink::WebInputEvent::GestureFlingCancel;
« no previous file with comments | « sky/framework/sky-scrollable.sky ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698