Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: Source/bindings/tests/results/core/V8TestNode.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestNode.cpp
diff --git a/Source/bindings/tests/results/core/V8TestNode.cpp b/Source/bindings/tests/results/core/V8TestNode.cpp
index 42368ebefe4cedaa9a8dd58546315cc5ffe39df0..7100e74085b3e544142aa3d06b2ea30e63cec986 100644
--- a/Source/bindings/tests/results/core/V8TestNode.cpp
+++ b/Source/bindings/tests/results/core/V8TestNode.cpp
@@ -48,7 +48,9 @@ static void hrefAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Property
{
v8::Local<v8::Object> holder = info.Holder();
TestNode* impl = V8TestNode::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ V8StringResource<> cppValue = v8Value;
+ if (!cppValue.prepare())
+ return;
impl->setHref(cppValue);
}
@@ -78,7 +80,9 @@ static void hrefThrowsAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Pr
v8::Local<v8::Object> holder = info.Holder();
ExceptionState exceptionState(ExceptionState::SetterContext, "hrefThrows", "TestNode", holder, info.GetIsolate());
TestNode* impl = V8TestNode::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ V8StringResource<> cppValue = v8Value;
+ if (!cppValue.prepare())
+ return;
impl->setHrefThrows(cppValue, exceptionState);
exceptionState.throwIfNeeded();
}
@@ -108,7 +112,9 @@ static void hrefCallWithAttributeSetter(v8::Local<v8::Value> v8Value, const v8::
{
v8::Local<v8::Object> holder = info.Holder();
TestNode* impl = V8TestNode::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ V8StringResource<> cppValue = v8Value;
+ if (!cppValue.prepare())
+ return;
ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
impl->setHrefCallWith(executionContext, callingDOMWindow(info.GetIsolate()), enteredDOMWindow(info.GetIsolate()), cppValue);
}
@@ -139,7 +145,9 @@ static void hrefByteStringAttributeSetter(v8::Local<v8::Value> v8Value, const v8
v8::Local<v8::Object> holder = info.Holder();
ExceptionState exceptionState(ExceptionState::SetterContext, "hrefByteString", "TestNode", holder, info.GetIsolate());
TestNode* impl = V8TestNode::toImpl(holder);
- TONATIVE_VOID_EXCEPTIONSTATE(V8StringResource<>, cppValue, toByteString(v8Value, exceptionState), exceptionState);
+ V8StringResource<> cppValue = toByteString(v8Value, exceptionState);
+ if (exceptionState.throwIfNeeded())
+ return;
impl->setHrefByteString(cppValue);
}

Powered by Google App Engine
This is Rietveld 408576698