Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp
index fe86e60b045e18cf31762e578eb2f9bf7c43c68f..7bcdd8ae7d512946c0ae7d9f0a45f5244e5362b7 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp
@@ -89,7 +89,9 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
}
V8StringResource<> str;
{
- TOSTRING_VOID_INTERNAL(str, info[0]);
+ str = info[0];
+ if (!str.prepare())
+ return;
}
RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::create(str);
v8::Local<v8::Object> wrapper = info.Holder();
@@ -122,7 +124,9 @@ static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::F
}
V8StringResource<> str;
{
- TOSTRING_VOID_INTERNAL(str, info[0]);
+ str = info[0];
+ if (!str.prepare())
+ return;
}
RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::createForJSConstructor(str);
v8::Local<v8::Object> wrapper = info.Holder();
« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/core/V8TestNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698