Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp b/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
index 4edd95c60e9b543a975e71c1eff491ce3d1223fe..f936b1400efec05099dbfa28695fb9751b560be7 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
@@ -63,7 +63,9 @@ static void doNotCheckSecurityLongAttributeAttributeSetter(v8::Local<v8::Value>
v8::Local<v8::Object> holder = info.Holder();
ExceptionState exceptionState(ExceptionState::SetterContext, "doNotCheckSecurityLongAttribute", "TestInterfaceCheckSecurity", holder, info.GetIsolate());
TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
- TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
+ int cppValue = toInt32(v8Value, exceptionState);
+ if (exceptionState.throwIfNeeded())
+ return;
impl->setDoNotCheckSecurityLongAttribute(cppValue);
}
@@ -107,7 +109,9 @@ static void doNotCheckSecurityOnSetterLongAttributeAttributeSetter(v8::Local<v8:
v8::Local<v8::Object> holder = info.Holder();
ExceptionState exceptionState(ExceptionState::SetterContext, "doNotCheckSecurityOnSetterLongAttribute", "TestInterfaceCheckSecurity", holder, info.GetIsolate());
TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
- TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
+ int cppValue = toInt32(v8Value, exceptionState);
+ if (exceptionState.throwIfNeeded())
+ return;
impl->setDoNotCheckSecurityOnSetterLongAttribute(cppValue);
}

Powered by Google App Engine
This is Rietveld 408576698