Source/bindings/tests/results/core/V8TestInterface3.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface3.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface2.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface3.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface3.cpp b/Source/bindings/tests/results/core/V8TestInterface3.cpp

index 14153ac35aaf1231f270c3599b9646d460d53c69..3af22e148aea65cf7b438a6c892e43c2ae36c8be 100644

--- a/Source/bindings/tests/results/core/V8TestInterface3.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface3.cpp

@@ -94,7 +94,9 @@ static void voidMethodDocumentMethod(const v8::FunctionCallbackInfo<v8::Value>&

exceptionState.throwIfNeeded();

return;

}

- TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(d, toRestrictedDouble(info[1], exceptionState), exceptionState);

+ d = toRestrictedDouble(info[1], exceptionState);

+ if (exceptionState.throwIfNeeded())

+ return;

}

TestPartialInterface4::voidMethodDocument(document, d);

}

@@ -163,7 +165,7 @@ static void forEachMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

if (!info[0]->IsFunction()) {

exceptionState.throwTypeError("The callback provided as parameter 1 is not a function.");

- exceptionState.throwIfNeeded();

+ exceptionState.throwIfNeeded();

return;

}

callback = ScriptValue(ScriptState::current(info.GetIsolate()), info[0]);