Source/bindings/scripts/v8_union.py - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_union.py

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_union.py

diff --git a/Source/bindings/scripts/v8_union.py b/Source/bindings/scripts/v8_union.py

index 4ed138fac624837e7d9b30a32819fd6e9c5c1986..177394ea23e57d6ad0484a2103b99c78ffec8432 100644

--- a/Source/bindings/scripts/v8_union.py

+++ b/Source/bindings/scripts/v8_union.py

@@ -150,5 +150,5 @@ def member_context(member, interfaces_info):

'type_name': member.name,

'v8_value_to_local_cpp_value': member.v8_value_to_local_cpp_value(

{}, 'v8Value', 'cppValue', isolate='isolate',

- needs_exception_state_for_string=True, restricted_float=True),

+ use_exception_state=True, restricted_float=True),

}

« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »