Source/bindings/scripts/v8_union.py - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/scripts/v8_union.py

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import v8_utilities	5 import v8_utilities

6	6

7	7

8 UNION_H_INCLUDES = frozenset([	8 UNION_H_INCLUDES = frozenset([

9 'bindings/core/v8/Dictionary.h',	9 'bindings/core/v8/Dictionary.h',

10 'bindings/core/v8/ExceptionState.h',	10 'bindings/core/v8/ExceptionState.h',

(...skipping 132 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
143 'cpp_value_to_v8_value': member.cpp_value_to_v8_value(	143 'cpp_value_to_v8_value': member.cpp_value_to_v8_value(

144 cpp_value='impl.getAs%s()' % member.name, isolate='isolate',	144 cpp_value='impl.getAs%s()' % member.name, isolate='isolate',

145 creation_context='creationContext'),	145 creation_context='creationContext'),

146 'enum_validation_expression': member.enum_validation_expression,	146 'enum_validation_expression': member.enum_validation_expression,

147 'is_traceable': member.is_traceable,	147 'is_traceable': member.is_traceable,

148 'rvalue_cpp_type': member.cpp_type_args(used_as_rvalue_type=True),	148 'rvalue_cpp_type': member.cpp_type_args(used_as_rvalue_type=True),

149 'specific_type_enum': 'SpecificType' + member.name,	149 'specific_type_enum': 'SpecificType' + member.name,

150 'type_name': member.name,	150 'type_name': member.name,

151 'v8_value_to_local_cpp_value': member.v8_value_to_local_cpp_value(	151 'v8_value_to_local_cpp_value': member.v8_value_to_local_cpp_value(

152 {}, 'v8Value', 'cppValue', isolate='isolate',	152 {}, 'v8Value', 'cppValue', isolate='isolate',

153 needs_exception_state_for_string=True, restricted_float=True),	153 use_exception_state=True, restricted_float=True),

154 }	154 }

OLD	NEW