Source/bindings/tests/results/core/V8TestSpecialOperations.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_types.py ('K') | « Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp ('k') | Source/bindings/tests/results/core/V8TestTypedefs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

diff --git a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

index ea4cbb766dd8e0fcdf51e17dfd2e28a6a45095dc..2482aed8628888fb7cb9d01fa3f9e1b7794ab660 100644

--- a/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

+++ b/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

@@ -45,7 +45,7 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

TestSpecialOperations* impl = V8TestSpecialOperations::toImpl(info.Holder());

V8StringResource<> name;

{

- TOSTRING_VOID_INTERNAL(name, info[0]);

+ TONATIVE_CONVERT((name = info[0]).prepare(), return);

}

NodeOrNodeList result;

impl->getItem(name, result);