Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
diff --git a/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp b/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
index d6bce6e8ea1fdc358f0662cfbe10761df4c9570d..803207832b5ae43407599500093715dc112cc8d7 100644
--- a/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
+++ b/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
@@ -11,13 +11,13 @@
namespace blink {
-void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestPermissiveDictionary& impl, ExceptionState& exceptionState)
+bool V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestPermissiveDictionary& impl, ExceptionState& exceptionState)
{
if (isUndefinedOrNull(v8Value))
- return;
+ return true;
if (!v8Value->IsObject()) {
// Do nothing.
- return;
+ return true;
}
v8::Local<v8::Object> v8Object = v8Value->ToObject(isolate);
@@ -25,7 +25,7 @@ void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Valu
v8::Local<v8::Value> booleanMemberValue = v8Object->Get(v8String(isolate, "booleanMember"));
if (block.HasCaught()) {
exceptionState.rethrowV8Exception(block.Exception());
- return;
+ return false;
}
if (booleanMemberValue.IsEmpty() || booleanMemberValue->IsUndefined()) {
// Do nothing.
@@ -34,6 +34,7 @@ void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Valu
impl.setBooleanMember(booleanMember);
}
+ return true;
}
v8::Local<v8::Value> toV8(const TestPermissiveDictionary& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)

Powered by Google App Engine
This is Rietveld 408576698