Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_types.py ('K') | « Source/bindings/tests/results/core/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/core/V8TestNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

index fe86e60b045e18cf31762e578eb2f9bf7c43c68f..319296e9d86f5d9c9836ec8e045d715d67ce5ca7 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -89,7 +89,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

}

V8StringResource<> str;

{

- TOSTRING_VOID_INTERNAL(str, info[0]);

+ TONATIVE_CONVERT((str = info[0]).prepare(), return);

}

RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::create(str);

v8::Local<v8::Object> wrapper = info.Holder();

@@ -122,7 +122,7 @@ static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::F

}

V8StringResource<> str;

{

- TOSTRING_VOID_INTERNAL(str, info[0]);

+ TONATIVE_CONVERT((str = info[0]).prepare(), return);

}

RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::createForJSConstructor(str);

v8::Local<v8::Object> wrapper = info.Holder();