Chromium Code Reviews

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
index 7dda941231798ef260bcce413005fc4e9b6ed18e..469e21bdacbafcf8aa2ad25684f1a28dd12a192b 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
@@ -52,7 +52,7 @@ static void stringAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v
{
v8::Local<v8::Object> holder = info.Holder();
TestInterfaceNode* impl = V8TestInterfaceNode::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ TONATIVE_DECLARE(V8StringResource<>, cppValue, (cppValue = v8Value).prepare(), return);
impl->setStringAttribute(cppValue);
}
@@ -152,7 +152,7 @@ static void reflectStringAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
{
v8::Local<v8::Object> holder = info.Holder();
Element* impl = V8Element::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ TONATIVE_DECLARE(V8StringResource<>, cppValue, (cppValue = v8Value).prepare(), return);
impl->setAttribute(HTMLNames::reflectstringattributeAttr, cppValue);
}
@@ -182,7 +182,7 @@ static void reflectUrlStringAttributeAttributeSetter(v8::Local<v8::Value> v8Valu
{
v8::Local<v8::Object> holder = info.Holder();
Element* impl = V8Element::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, cppValue, v8Value);
+ TONATIVE_DECLARE(V8StringResource<>, cppValue, (cppValue = v8Value).prepare(), return);
impl->setAttribute(HTMLNames::reflecturlstringattributeAttr, cppValue);
}

Powered by Google App Engine