Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 946933006: Default SK_ANGLE to true on Windows, run angle whenever possible on bots. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Default SK_ANGLE to true on Windows, run angle whenever possible on bots. nanobench doesn't need an update. It uses the default for --config, which includes angle. BUG=skia: Committed: https://skia.googlesource.com/skia/+/88ec329b580a081d9d56cbcaad0ee46cb941c849

Patch Set 1 #

Patch Set 2 : golden #

Patch Set 3 : ANGLE bot isn't special anymore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M gyp/common_variables.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M tools/dm_flags.json View 1 2 5 chunks +4 lines, -19 lines 0 comments Download
M tools/dm_flags.py View 1 2 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein_C
Here's how to run ANGLE everywhere. We can tear down the ad-hoc -ANGLE bot after ...
5 years, 10 months ago (2015-02-25 02:05:45 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-25 15:34:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946933006/40001
5 years, 10 months ago (2015-02-25 15:44:52 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/88ec329b580a081d9d56cbcaad0ee46cb941c849
5 years, 10 months ago (2015-02-25 15:56:10 UTC) #6
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/954243002/ by mtklein@google.com. ...
5 years, 10 months ago (2015-02-25 16:15:08 UTC) #7
bsalomon
5 years, 9 months ago (2015-02-26 15:56:30 UTC) #8
Message was sent while issue was closed.
On 2015/02/25 16:15:08, mtklein wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/954243002/ by mailto:mtklein@google.com.
> 
> The reason for reverting is: Needs bot upgrades..

Just noting that next time we try this I don't think we should make skia_angle
default to 1 in common_variables.gypi simply because setting that var to 1 is
really only desirable for skia developers and testing.

Powered by Google App Engine
This is Rietveld 408576698