Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/dm_flags.py

Issue 946933006: Default SK_ANGLE to true on Windows, run angle whenever possible on bots. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: ANGLE bot isn't special anymore Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 985a62adf573e2cad0110187b64924cd942bb368..c41a003c51d0d8e4cfc4f41c606e3f73bec27e24 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -22,15 +22,13 @@ cov_start = lineno()+1 # We care about coverage starting just past this def.
def get_args(bot):
args = []
- configs = ['565', '8888', 'gpu', 'nvprmsaa4']
+ configs = ['565', '8888', 'gpu', 'nvprmsaa4', 'angle']
# Xoom and NP are running out of RAM when we run all these modes. skia:3255
if ('Xoom' not in bot and
'NexusPlayer' not in bot):
configs.extend(mode + '-8888' for mode in
['serialize', 'tiles_rt', 'pipe'])
configs.append('tiles_rt-gpu')
- if 'ANGLE' in bot:
- configs.append('angle')
args.append('--config')
args.extend(configs)
@@ -88,7 +86,6 @@ def self_test():
'Test-Android-Xoom-Tegra2-Arm7-Release',
'Test-ChromeOS-Alex-GMA3150-x86-Debug',
'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind',
- 'Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE',
]
cov = coverage.coverage()
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698