Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 946753002: Delete a bunch of dead python code. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete a bunch of dead python code. Just deleted the obvious bits and verified that test_sky, skydb and pretty-diff still work. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/30695ccc41fa37b9f77781e2c25a8c0abe1d8d6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10916 lines) Patch
D sky/tools/read_checksum_from_png View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/tools/run_sky_httpd View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/tools/run_sky_websocketserver View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/tools/webkit-patch View 1 chunk +0 lines, -86 lines 0 comments Download
M sky/tools/webkitpy/thirdparty/README.chromium View 2 chunks +2 lines, -32 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/__init__.py View 1 chunk +0 lines, -88 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/__main__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/annotate.py View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/backward.py View 1 chunk +0 lines, -147 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/bytecode.py View 1 chunk +0 lines, -90 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/cmdline.py View 1 chunk +0 lines, -677 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/codeunit.py View 1 chunk +0 lines, -117 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/collector.py View 1 chunk +0 lines, -321 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/config.py View 1 chunk +0 lines, -164 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/control.py View 1 chunk +0 lines, -688 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/data.py View 1 chunk +0 lines, -273 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/execfile.py View 1 chunk +0 lines, -133 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/files.py View 1 chunk +0 lines, -219 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/fullcoverage/encodings.py View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/html.py View 1 chunk +0 lines, -328 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/coverage_html.js View 1 chunk +0 lines, -372 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/index.html View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/jquery-1.4.3.min.js View 1 chunk +0 lines, -166 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/jquery.hotkeys.js View 1 chunk +0 lines, -99 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/jquery.isonscreen.js View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/jquery.tablesorter.min.js View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/keybd_closed.png View Binary file 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/keybd_open.png View Binary file 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/pyfile.html View 1 chunk +0 lines, -87 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/htmlfiles/style.css View 1 chunk +0 lines, -275 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/misc.py View 1 chunk +0 lines, -139 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/parser.py View 1 chunk +0 lines, -650 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/phystokens.py View 1 chunk +0 lines, -108 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/report.py View 1 chunk +0 lines, -89 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/results.py View 1 chunk +0 lines, -247 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/summary.py View 1 chunk +0 lines, -81 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/templite.py View 1 chunk +0 lines, -166 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/tracer.c View 1 chunk +0 lines, -719 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/coverage/xmlreport.py View 1 chunk +0 lines, -147 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/__init__.py View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/abstractlocalservercommand.py View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/abstractsequencedcommand.py View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/commandtest.py View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/prettydiff.py View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/queries.py View 1 chunk +0 lines, -212 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/queries_unittest.py View 1 chunk +0 lines, -159 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/rebaseline.py View 1 chunk +0 lines, -945 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +0 lines, -1267 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/stepsequence.py View 1 chunk +0 lines, -87 lines 0 comments Download
D sky/tools/webkitpy/tool/main.py View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/tools/webkitpy/tool/mocktool.py View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/tools/webkitpy/tool/mocktool_unittest.py View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/tools/webkitpy/tool/multicommandtool.py View 1 chunk +0 lines, -319 lines 0 comments Download
D sky/tools/webkitpy/tool/multicommandtool_unittest.py View 1 chunk +0 lines, -173 lines 0 comments Download
D sky/tools/webkitpy/tool/steps/__init__.py View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/tools/webkitpy/tool/steps/abstractstep.py View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/tools/webkitpy/tool/steps/confirmdiff.py View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/tools/webkitpy/tool/steps/options.py View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-21 05:09:06 UTC) #2
ojan
5 years, 10 months ago (2015-02-21 05:09:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
30695ccc41fa37b9f77781e2c25a8c0abe1d8d6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698