Chromium Code Reviews Chromium Code Reviews
Issue 946553003:
[CSS Grid Layout] Avoid reset override logical width/height for non relative elements (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html |
| diff --git a/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html b/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html |
| index d84f503b0d77b3e97215c1476923e25efadae3a7..7829f698c88f06b8c1b1db41d3f1c9ae01bc864e 100644 |
| --- a/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html |
| +++ b/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html |
| @@ -11,6 +11,12 @@ |
| grid-template-columns: 50px 100px; |
| grid-template-rows: auto auto; |
| } |
| + |
| +.sizedToGridAreaMinSizes { |
| + font: 10px/1 Ahem; |
| + min-width: 100%; |
| + min-height: 100%; |
|
Julien - ping for review
2015/03/02 18:05:20
Let's add similar testing for max-width / max-heig
Manuel Rego
2015/03/05 06:31:07
Done.
|
| +} |
| </style> |
| <script src="../../resources/check-layout.js"></script> |
| <body onload="checkLayout('.grid')"> |
| @@ -53,5 +59,41 @@ |
| </div> |
| </div> |
| +<div class="unconstrainedContainer" style="position: relative"> |
| +<div class="grid gridMinMaxMinMax"> |
| + <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width="50" data-expected-height="20">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-width="100" data-expected-height="20">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-width="50" data-expected-height="100">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-width="100" data-expected-height="100">XXXXX XXXXXX</div> |
| +</div> |
| +</div> |
| + |
| +<div style="position: relative; height: 100px;"> |
| +<div class="grid gridMinMaxMinMax"> |
| + <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width="50" data-expected-height="20">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-width="100" data-expected-height="20">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-width="50" data-expected-height="100">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-width="100" data-expected-height="100">XXXXX XXXXXX</div> |
| +</div> |
| +</div> |
| + |
| +<div style="position: relative;"> |
| +<div class="grid gridMinMaxMinMax" style="height: 100px;"> |
| + <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width="50" data-expected-height="20">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-width="100" data-expected-height="20">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-width="50" data-expected-height="80">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-width="100" data-expected-height="80">XXXXX XXXXXX</div> |
| +</div> |
| +</div> |
| + |
| +<div class="unconstrainedContainer" style="position: relative"> |
| +<div class="grid gridAutoAuto"> |
| + <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width="50" data-expected-height="30">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-width="100" data-expected-height="30">XXXXX XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-width="50" data-expected-height="40">XXXXX XXXXXX</div> |
| + <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-width="100" data-expected-height="40">XXXXX XXXXX XXXXX XXXXXX</div> |
| +</div> |
| +</div> |
| + |
| </body> |
| </html> |
