content/browser/browser_side_navigation_browsertest.cc - Issue 946543003: PlzNavigate: have renderer-initiated navigations be same-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_side_navigation_browsertest.cc

Issue 946543003: PlzNavigate: have renderer-initiated navigations be same-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment changes and browsertest fix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/frame_host/navigator_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_side_navigation_browsertest.cc

diff --git a/content/browser/browser_side_navigation_browsertest.cc b/content/browser/browser_side_navigation_browsertest.cc

index c22dc7ef74c57a4863edfb9a667140469d1a6120..92b1a5a472b562b3393cae1cce242248c4924402 100644

--- a/content/browser/browser_side_navigation_browsertest.cc

+++ b/content/browser/browser_side_navigation_browsertest.cc

@@ -155,7 +155,7 @@ IN_PROC_BROWSER_TEST_F(BrowserSideNavigationBrowserTest,

}

// The RenderFrameHost should have changed.

clamy 2015/03/06 15:57:50 Change the comment to "should not have changed."

carlosk 2015/03/06 16:34:08 Done.

- EXPECT_NE(initial_rfh, static_cast<WebContentsImpl*>(shell()->web_contents())

+ EXPECT_EQ(initial_rfh, static_cast<WebContentsImpl*>(shell()->web_contents())

->GetFrameTree()->root()->current_frame_host());

}

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/frame_host/navigator_impl_unittest.cc » ('J')