content/browser/browser_side_navigation_browsertest.cc - Issue 946543003: PlzNavigate: have renderer-initiated navigations be same-process

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/browser_side_navigation_browsertest.cc

Issue 946543003: PlzNavigate: have renderer-initiated navigations be same-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment changes and browsertest fix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/frame_host/navigator_impl_unittest.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/basictypes.h"	5 #include "base/basictypes.h"

6 #include "base/command_line.h"	6 #include "base/command_line.h"

7 #include "base/strings/stringprintf.h"	7 #include "base/strings/stringprintf.h"

8 #include "content/browser/web_contents/web_contents_impl.h"	8 #include "content/browser/web_contents/web_contents_impl.h"

9 #include "content/public/browser/web_contents.h"	9 #include "content/public/browser/web_contents.h"

10 #include "content/public/common/content_switches.h"	10 #include "content/public/common/content_switches.h"

(...skipping 136 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
147 EXPECT_TRUE(ExecuteScriptAndExtractBool(	147 EXPECT_TRUE(ExecuteScriptAndExtractBool(

148 shell()->web_contents(),	148 shell()->web_contents(),

149 "window.domAutomationController.send(clickCrossSiteLink());",	149 "window.domAutomationController.send(clickCrossSiteLink());",

150 &success));	150 &success));

151 EXPECT_TRUE(success);	151 EXPECT_TRUE(success);

152 EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));	152 EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));

153 EXPECT_EQ(url, observer.last_navigation_url());	153 EXPECT_EQ(url, observer.last_navigation_url());

154 EXPECT_TRUE(observer.last_navigation_succeeded());	154 EXPECT_TRUE(observer.last_navigation_succeeded());

155 }	155 }

156	156

157 // The RenderFrameHost should have changed.	157 // The RenderFrameHost should have changed.
	clamy 2015/03/06 15:57:50 Change the comment to "should not have changed." Change the comment to "should not have changed." carlosk 2015/03/06 16:34:08 Done. Show quoted text On 2015/03/06 15:57:50, clamy wrote: > Change the comment to "should not have changed." Done.
158 EXPECT_NE(initial_rfh, static_cast<WebContentsImpl*>(shell()->web_contents())	158 EXPECT_EQ(initial_rfh, static_cast<WebContentsImpl*>(shell()->web_contents())

159 ->GetFrameTree()->root()->current_frame_host());	159 ->GetFrameTree()->root()->current_frame_host());

160 }	160 }

161	161

162 } // namespace content	162 } // namespace content

OLD	NEW