Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 946423004: nacl sdk: build tools: add filesystem permissions to apps (Closed)

Created:
5 years, 10 months ago by llandwerlin-old
Modified:
5 years, 9 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nacl sdk: build tools: add filesystem permissions to apps BUG=461785 Committed: https://crrev.com/4ba540fe52e02a87065441a21ed94a41adc42799 Cr-Commit-Position: refs/heads/master@{#318733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M native_client_sdk/src/build_tools/build_app.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
llandwerlin-old
Hi Ben, I had a similar CL to the one you landed in November : ...
5 years, 10 months ago (2015-02-25 12:48:47 UTC) #2
binji
Thanks! build_app.py is only run manually, so I haven't tested it in a while. But ...
5 years, 9 months ago (2015-03-02 18:27:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946423004/1
5 years, 9 months ago (2015-03-02 18:30:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 19:14:27 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 19:14:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ba540fe52e02a87065441a21ed94a41adc42799
Cr-Commit-Position: refs/heads/master@{#318733}

Powered by Google App Engine
This is Rietveld 408576698