Issue 690403002: [NaCl SDK] Add filesystem passing example.

Issue 690403002: [NaCl SDK] Add filesystem passing example. (Closed)

Created:
6 years, 1 month ago by binji

Modified:
6 years, 1 month ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Add filesystem passing example. BUG=none R=sbc@chromium.org Committed: https://crrev.com/c9d938c57d41fa3bdf4b18264631cff4ffdff303 Cr-Commit-Position: refs/heads/master@{#302480}

Patch Set 3 : fixes #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -1 line)			Patch
M	native_client_sdk/src/build_tools/generate_make.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	native_client_sdk/src/build_tools/parse_dsc.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/build_tools/sdk_files.list	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/examples/tutorial/filesystem_passing/example.js	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/examples/tutorial/filesystem_passing/filesystem_passing.cc	View		1 chunk	+114 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/examples/tutorial/filesystem_passing/index.html	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

lgtm https://codereview.chromium.org/690403002/diff/20001/native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc File native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc (right): https://codereview.chromium.org/690403002/diff/20001/native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc#newcode23 native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc:23: remove trailing newline

6 years, 1 month ago (2014-11-03 21:05:06 UTC) #2

binji

https://codereview.chromium.org/690403002/diff/20001/native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc File native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc (right): https://codereview.chromium.org/690403002/diff/20001/native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc#newcode23 native_client_sdk/src/examples/tutorial/filesystem_passing/example.dsc:23: On 2014/11/03 21:05:06, Sam Clegg wrote: > remove trailing ...

6 years, 1 month ago (2014-11-03 21:18:41 UTC) #3

binji

Committed patchset #3 (id:40001) manually as c9d938c57d41fa3bdf4b18264631cff4ffdff303 (presubmit successful).

6 years, 1 month ago (2014-11-03 21:20:40 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 21:20:42 UTC) #5

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/c9d938c57d41fa3bdf4b18264631cff4ffdff303
Cr-Commit-Position: refs/heads/master@{#302480}

Expand Messages | Collapse Messages