Animations: Introduce compositor AnimationPlayer and AnimationTimeline.

Source/web/ChromeClientImpl.cpp

Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 98377cec588585c34a4b2762d7e0ef5df5921c5c..8200bb4b80a3065bb92f10d277db21511c119511 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -34,6 +34,7 @@
 
 #include "bindings/core/v8/ScriptController.h"
 #include "core/HTMLNames.h"
+#include "core/animation/AnimationTimeline.h"
 #include "core/dom/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/Fullscreen.h"
@@ -107,6 +108,8 @@
 
 namespace blink {
 
+class WebCompositorAnimationTimeline;
+
 // Converts a AXObjectCache::AXNotification to a WebAXEvent
 static WebAXEvent toWebAXEvent(AXObjectCache::AXNotification notification)
 {
@@ -691,19 +694,24 @@ GraphicsLayerFactory* ChromeClientImpl::graphicsLayerFactory() const
 
 void ChromeClientImpl::attachRootGraphicsLayer(GraphicsLayer* rootLayer, LocalFrame* localRoot)
 {
+    WebCompositorAnimationTimeline* compositorTimeline = rootLayer && localRoot->document() ? localRoot->document()->timeline().compositorTimeline() : nullptr;
+
     // FIXME: For top-level frames we still use the WebView as a WebWidget. This special
     // case will be removed when top-level frames get WebFrameWidgets.
     if (localRoot->isMainFrame()) {
+        m_webView->setCompositorAnimationTimeline(compositorTimeline);

[aelias_OOO_until_Jul13, 2015/03/13 00:38:32]

This looks out of place here, a better place might be in
WebViewImpl::initializeLayerTreeView()?

[loyso (OOO), 2015/03/13 01:07:01]

Not sure how to do that.
1) CompositorTimeline object is owned by blink::Timeline (DocumentTimeline in
the future)
2) We want to swap them as we do for WebLayer's
3) There will be many Timeline objects.

[aelias_OOO_until_Jul13, 2015/03/13 01:31:18]

Sorry, I don't follow right now how these points relate to whether this
initialization-time code should happen here or in initializeLayerTreeView.  I
think moving this call would still work regardless, are you talking about later
stages of the refactoring?  It doesn't belong in attachRootGraphicsLayer in any
case since it has nothing to do with the root graphics layer.

[loyso (OOO), 2015/03/13 03:37:42]

I want compositor timeline to be attached/detached within
Document::attach/Document::detach scope. That's not purely initialization-time
code.

The question: where can I take a pointer to WebCompositorAnimationTimeline
object for a given Document (i.e. LocalFrame* localRoot)?

page()->mainFrame() isn't yet defined in WebViewImpl::initializeLayerTreeView().

Apart from that, you are right that it doesn't belong to attachRootGraphicsLayer
in any
case. I could plumb
ChromeClientImpl::attachCompositorAnimationTimeline(WebCompositorAnimationTimeline*,
LocalFrame* localRoot) to call it from Document::attach/Document::detach scope.
Any help how to route this would be much appreciated!

[aelias_OOO_until_Jul13, 2015/03/17 18:12:27]

OK, looking at that, the plumbing would be pretty redundant with this, so I
guess it's fine to leave here.

[loyso (OOO), 2015/03/18 06:59:43]

Ok. But I could put a note or TODO comment here.

         m_webView->setRootGraphicsLayer(rootLayer);
     } else {
         WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(localRoot);
         // FIXME: The following conditional is only needed for staging until the Chromium patch
         // lands that instantiates a WebFrameWidget.
         if (!webFrame->frameWidget()) {
+            m_webView->setCompositorAnimationTimeline(compositorTimeline);
             m_webView->setRootGraphicsLayer(rootLayer);
             return;
         }
         ASSERT(webFrame && webFrame->frameWidget());
+        webFrame->frameWidget()->setCompositorAnimationTimeline(compositorTimeline);
         webFrame->frameWidget()->setRootGraphicsLayer(rootLayer);
     }
 }