Animations: Introduce compositor AnimationPlayer and AnimationTimeline.

Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 16 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "web/ChromeClientImpl.h"
 
 #include "bindings/core/v8/ScriptController.h"
 #include "core/HTMLNames.h"
+#include "core/animation/AnimationTimeline.h"
 #include "core/dom/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/Node.h"
 #include "core/frame/Console.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/forms/ColorChooser.h"
@@ skipping 53 matching lines @@
 #include "web/WebPopupMenuImpl.h"
 #include "web/WebSettingsImpl.h"
 #include "web/WebViewImpl.h"
 #include "wtf/text/CString.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/StringConcatenate.h"
 #include "wtf/unicode/CharacterNames.h"
 
 namespace blink {
 
+class WebCompositorAnimationTimeline;
+
 // Converts a AXObjectCache::AXNotification to a WebAXEvent
 static WebAXEvent toWebAXEvent(AXObjectCache::AXNotification notification)
 {
     // These enums have the same values; enforced in AssertMatchingEnums.cpp.
     return static_cast<WebAXEvent>(notification);
 }
 
 static WebSelectionBound toWebSelectionBound(const CompositedSelectionBound& bound)
 {
     ASSERT(bound.layer);
@@ skipping 564 matching lines @@
     return false;
 }
 
 GraphicsLayerFactory* ChromeClientImpl::graphicsLayerFactory() const
 {
     return m_webView->graphicsLayerFactory();
 }
 
 void ChromeClientImpl::attachRootGraphicsLayer(GraphicsLayer* rootLayer, LocalFrame* localRoot)
 {
+    WebCompositorAnimationTimeline* compositorTimeline = rootLayer && localRoot->document() ? localRoot->document()->timeline().compositorTimeline() : nullptr;
+
     // FIXME: For top-level frames we still use the WebView as a WebWidget. This special
     // case will be removed when top-level frames get WebFrameWidgets.
     if (localRoot->isMainFrame()) {
+        m_webView->setCompositorAnimationTimeline(compositorTimeline);

[aelias_OOO_until_Jul13, 2015/03/13 00:38:32]

This looks out of place here, a better place might be in
WebViewImpl::initializeLayerTreeView()?

[loyso (OOO), 2015/03/13 01:07:01]

Not sure how to do that.
1) CompositorTimeline object is owned by blink::Timeline (DocumentTimeline in
the future)
2) We want to swap them as we do for WebLayer's
3) There will be many Timeline objects.

[aelias_OOO_until_Jul13, 2015/03/13 01:31:18]

Sorry, I don't follow right now how these points relate to whether this
initialization-time code should happen here or in initializeLayerTreeView.  I
think moving this call would still work regardless, are you talking about later
stages of the refactoring?  It doesn't belong in attachRootGraphicsLayer in any
case since it has nothing to do with the root graphics layer.

[loyso (OOO), 2015/03/13 03:37:42]

I want compositor timeline to be attached/detached within
Document::attach/Document::detach scope. That's not purely initialization-time
code.

The question: where can I take a pointer to WebCompositorAnimationTimeline
object for a given Document (i.e. LocalFrame* localRoot)?

page()->mainFrame() isn't yet defined in WebViewImpl::initializeLayerTreeView().

Apart from that, you are right that it doesn't belong to attachRootGraphicsLayer
in any
case. I could plumb
ChromeClientImpl::attachCompositorAnimationTimeline(WebCompositorAnimationTimeline*,
LocalFrame* localRoot) to call it from Document::attach/Document::detach scope.
Any help how to route this would be much appreciated!

[aelias_OOO_until_Jul13, 2015/03/17 18:12:27]

OK, looking at that, the plumbing would be pretty redundant with this, so I
guess it's fine to leave here.

[loyso (OOO), 2015/03/18 06:59:43]

Ok. But I could put a note or TODO comment here.

         m_webView->setRootGraphicsLayer(rootLayer);
     } else {
         WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(localRoot);
         // FIXME: The following conditional is only needed for staging until the Chromium patch
         // lands that instantiates a WebFrameWidget.
         if (!webFrame->frameWidget()) {
+            m_webView->setCompositorAnimationTimeline(compositorTimeline);
             m_webView->setRootGraphicsLayer(rootLayer);
             return;
         }
         ASSERT(webFrame && webFrame->frameWidget());
+        webFrame->frameWidget()->setCompositorAnimationTimeline(compositorTimeline);
         webFrame->frameWidget()->setRootGraphicsLayer(rootLayer);
     }
 }
 
 void ChromeClientImpl::enterFullScreenForElement(Element* element)
 {
     m_webView->enterFullScreenForElement(element);
 }
 
 void ChromeClientImpl::exitFullScreenForElement(Element* element)
@@ skipping 167 matching lines @@
     if (m_webView->rootGraphicsLayer() && m_webView->layerTreeView() && m_webView->pinchVirtualViewportEnabled())
         m_webView->page()->frameHost().pinchViewport().registerLayersWithTreeView(m_webView->layerTreeView());
 }
 
 void ChromeClientImpl::didUpdateTopControls() const
 {
     m_webView->didUpdateTopControls();
 }
 
 } // namespace blink