DescriptionAdd base_unittests to win8 trybot. Fix PEImage tests.
Two fixes were required to work on win8:
1. To determine if a directory is a reparse point, use GetFileInformation() since using WIN32_FIND_DATA.dwFileAttributes doesn't work on Windows 8. See https://msdn.microsoft.com/en-us/library/windows/desktop/aa363940.aspx
2. Update the PE image tests to use its own binary, change the expectation format, add support for Win 8.1 and re-enable on 64-bit.
BUG=373973, 167707
Committed: https://crrev.com/b820f17a3767400dac00242c7ee5a948088a0b27
Cr-Commit-Position: refs/heads/master@{#317960}
Patch Set 1 #Patch Set 2 : fix base_unittests #Patch Set 3 : testing bots #Patch Set 4 : bots are win8.1 #Patch Set 5 : enable 64-bit. win8 values. #Patch Set 6 : merge 948593004 #Patch Set 7 : expectation logic fix #
Total comments: 45
Patch Set 8 : code review comments. #Patch Set 9 : fix expectations #
Total comments: 6
Patch Set 10 : code review comments #Patch Set 11 : namespace the callbacks #
Total comments: 1
Messages
Total messages: 27 (7 generated)
|