Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 948593004: Rework PE image tests to use a compiled DLL instead of a system one. (Closed)

Created:
5 years, 10 months ago by Will Harris
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rework PE image tests to use a compiled DLL instead of a system one. Also change the expectation format to make it more flexible to support future configurations. BUG=167707

Patch Set 1 #

Patch Set 2 : win8 bot as well #

Patch Set 3 : add files! #

Patch Set 4 : isolate #

Patch Set 5 : new expectation format #

Patch Set 6 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -140 lines) Patch
M base/base.gyp View 1 2 3 4 5 2 chunks +18 lines, -0 lines 0 comments Download
M base/base_unittests.isolate View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A + base/win/pe_image_test.cc View 1 2 3 4 5 1 chunk +5 lines, -7 lines 0 comments Download
M base/win/pe_image_unittest.cc View 1 2 3 4 5 3 chunks +164 lines, -133 lines 0 comments Download
M testing/buildbot/chromium_win8_trybot.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698