Issue 945973002: Add validation to ui::PageTransition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945973002: Add validation to ui::PageTransition. (Closed)

Created:
5 years, 10 months ago by Martin Barbella

Modified:
5 years, 10 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add validation to ui::PageTransition. Part of this is used as a bitmask, but in some cases we assume that the core part is <= |PAGE_TRANSITION_LAST_CORE|. See: https://cluster-fuzz.appspot.com/testcase?key=4815416552062976 R=tsepez@chromium.org BUG=450268 Committed: https://crrev.com/4e28efbd6a4a30a51815a9011b124cc5cf230d2e Cr-Commit-Position: refs/heads/master@{#317458}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	content/public/common/common_param_traits_macros.h	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945973002/1

5 years, 10 months ago (2015-02-20 23:20:08 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-21 00:50:12 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4e28efbd6a4a30a51815a9011b124cc5cf230d2e
Cr-Commit-Position: refs/heads/master@{#317458}