content/public/common/common_param_traits_macros.h - Issue 945973002: Add validation to ui::PageTransition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/common_param_traits_macros.h

Issue 945973002: Add validation to ui::PageTransition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/common_param_traits_macros.h

diff --git a/content/public/common/common_param_traits_macros.h b/content/public/common/common_param_traits_macros.h

index 1f619c0bf78678f721c9688af76373851839c873..df89031fd39fceb708edf02efe4bdcb3007c5cc4 100644

--- a/content/public/common/common_param_traits_macros.h

+++ b/content/public/common/common_param_traits_macros.h

@@ -28,7 +28,10 @@

#undef IPC_MESSAGE_EXPORT

#define IPC_MESSAGE_EXPORT CONTENT_EXPORT

-IPC_ENUM_TRAITS(ui::PageTransition) // Bitmask.

+IPC_ENUM_TRAITS_VALIDATE(ui::PageTransition,

+ ((value &

+ ui::PageTransition::PAGE_TRANSITION_CORE_MASK) <=

+ ui::PageTransition::PAGE_TRANSITION_LAST_CORE))

IPC_ENUM_TRAITS_MAX_VALUE(net::NetworkChangeNotifier::ConnectionType,

net::NetworkChangeNotifier::CONNECTION_LAST)

IPC_ENUM_TRAITS_MAX_VALUE(content::ConsoleMessageLevel,

« no previous file with comments | « no previous file | no next file » | no next file with comments »