Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2093)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java

Issue 945843003: [Cronet] Do not call into native adapter after it is destroyed in ChromiumUrlRequest.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..4749747b9056359893e519af7aca9adb9dd147a0
--- /dev/null
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java
@@ -0,0 +1,60 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;
+
+import android.test.suitebuilder.annotation.SmallTest;
+
+import org.chromium.base.test.util.Feature;
+
+import java.util.HashMap;
+
+public class ChromiumUrlRequestTest extends CronetTestBase {
+ private CronetTestActivity mActivity;
+
+ @Override
+ protected void setUp() throws Exception {
+ super.setUp();
+ mActivity = launchCronetTestApp();
+ assertNotNull(mActivity);
+ assertTrue(NativeTestServer.startNativeTestServer(
+ getInstrumentation().getTargetContext()));
+ }
+
+ @Override
+ protected void tearDown() throws Exception {
+ super.tearDown();
+ NativeTestServer.shutdownNativeTestServer();
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testGetHttpStatusCodeAfterAdapterDestroyed() throws Exception {
+ TestHttpUrlRequestListener listener = new TestHttpUrlRequestListener();
+ ChromiumUrlRequest request = (ChromiumUrlRequest) createRequest(
+ NativeTestServer.getEchoMethodURL(), listener);
+ request.resetAdapterForTesting();
+ assertEquals(0, request.getHttpStatusCode());
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testGetHttpStatusTextAfterAdapterDestroyed() throws Exception {
+ TestHttpUrlRequestListener listener = new TestHttpUrlRequestListener();
+ ChromiumUrlRequest request = (ChromiumUrlRequest) createRequest(
+ NativeTestServer.getEchoMethodURL(), listener);
+ request.resetAdapterForTesting();
+ assertEquals("", request.getHttpStatusText());
+ }
+
+ // FIXME: check with Matt and Misha, and add tests to test other native
+ // methods.
+
+ private HttpUrlRequest createRequest(
+ String url, HttpUrlRequestListener listener) {
+ HashMap<String, String> headers = new HashMap<String, String>();
+ return mActivity.mRequestFactory.createRequest(
+ url, HttpUrlRequest.REQUEST_PRIORITY_MEDIUM, headers, listener);
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698