Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java

Issue 945843003: [Cronet] Do not call into native adapter after it is destroyed in ChromiumUrlRequest.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.net;
6
7 import android.test.suitebuilder.annotation.SmallTest;
8
9 import org.chromium.base.test.util.Feature;
10
11 import java.util.HashMap;
12
13 public class ChromiumUrlRequestTest extends CronetTestBase {
14 private CronetTestActivity mActivity;
15
16 @Override
17 protected void setUp() throws Exception {
18 super.setUp();
19 mActivity = launchCronetTestApp();
20 assertNotNull(mActivity);
21 assertTrue(NativeTestServer.startNativeTestServer(
22 getInstrumentation().getTargetContext()));
23 }
24
25 @Override
26 protected void tearDown() throws Exception {
27 super.tearDown();
28 NativeTestServer.shutdownNativeTestServer();
29 }
30
31 @SmallTest
32 @Feature({"Cronet"})
33 public void testGetHttpStatusCodeAfterAdapterDestroyed() throws Exception {
34 TestHttpUrlRequestListener listener = new TestHttpUrlRequestListener();
35 ChromiumUrlRequest request = (ChromiumUrlRequest) createRequest(
36 NativeTestServer.getEchoMethodURL(), listener);
37 request.resetAdapterForTesting();
38 assertEquals(0, request.getHttpStatusCode());
39 }
40
41 @SmallTest
42 @Feature({"Cronet"})
43 public void testGetHttpStatusTextAfterAdapterDestroyed() throws Exception {
44 TestHttpUrlRequestListener listener = new TestHttpUrlRequestListener();
45 ChromiumUrlRequest request = (ChromiumUrlRequest) createRequest(
46 NativeTestServer.getEchoMethodURL(), listener);
47 request.resetAdapterForTesting();
48 assertEquals("", request.getHttpStatusText());
49 }
50
51 // FIXME: check with Matt and Misha, and add tests to test other native
52 // methods.
53
54 private HttpUrlRequest createRequest(
55 String url, HttpUrlRequestListener listener) {
56 HashMap<String, String> headers = new HashMap<String, String>();
57 return mActivity.mRequestFactory.createRequest(
58 url, HttpUrlRequest.REQUEST_PRIORITY_MEDIUM, headers, listener);
59 }
60 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698