Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 945743002: bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h (Closed)

Created:
5 years, 10 months ago by mdempsky
Modified:
5 years, 10 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h PolicyCompiler runs in a normal process context, so it doesn't require the extra low-levelness of SANDBOX_DIE. BUG=449357 Committed: https://crrev.com/deed70455d69ca62e4a5bfd2123a9376c5197797 Cr-Commit-Position: refs/heads/master@{#317265}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -44 lines) Patch
M sandbox/linux/bpf_dsl/policy_compiler.cc View 5 chunks +28 lines, -44 lines 1 comment Download
M sandbox/linux/bpf_dsl/trap_registry.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mdempsky
5 years, 10 months ago (2015-02-20 06:47:49 UTC) #2
jln (very slow on Chromium)
lgtm https://codereview.chromium.org/945743002/diff/1/sandbox/linux/bpf_dsl/policy_compiler.cc File sandbox/linux/bpf_dsl/policy_compiler.cc (left): https://codereview.chromium.org/945743002/diff/1/sandbox/linux/bpf_dsl/policy_compiler.cc#oldcode320 sandbox/linux/bpf_dsl/policy_compiler.cc:320: // because some SandboxBPF unit tests exercise it. ...
5 years, 10 months ago (2015-02-20 07:00:44 UTC) #3
mdempsky
On 2015/02/20 07:00:44, jln wrote: > So these disappeared? Cool, but I don't remember :) ...
5 years, 10 months ago (2015-02-20 07:05:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945743002/1
5 years, 10 months ago (2015-02-20 07:06:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 07:29:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/deed70455d69ca62e4a5bfd2123a9376c5197797 Cr-Commit-Position: refs/heads/master@{#317265}
5 years, 10 months ago (2015-02-20 07:31:03 UTC) #8
mdempsky
5 years, 10 months ago (2015-02-20 11:36:08 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/944763004/ by mdempsky@chromium.org.

The reason for reverting is: To allow https://codereview.chromium.org/937303005/
to submit..

Powered by Google App Engine
This is Rietveld 408576698