sandbox/linux/bpf_dsl/trap_registry.h - Issue 945743002: bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/bpf_dsl/trap_registry.h

Issue 945743002: bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/linux/bpf_dsl/trap_registry.h

diff --git a/sandbox/linux/bpf_dsl/trap_registry.h b/sandbox/linux/bpf_dsl/trap_registry.h

index 6f8d37a7f48842ffe1ac0778ef1f56e1caaa42d1..0a5d2f14cccfcd2c51ed80e7bfa39d8811d79464 100644

--- a/sandbox/linux/bpf_dsl/trap_registry.h

+++ b/sandbox/linux/bpf_dsl/trap_registry.h

@@ -49,6 +49,11 @@ class SANDBOX_EXPORT TrapRegistry {

// EnableUnsafeTraps tries to enable unsafe traps and returns

// whether it was successful. This is a one-way operation.

+ //

+ // CAUTION: Enabling unsafe traps effectively defeats the security

+ // guarantees provided by the sandbox policy. TrapRegistry

+ // implementations should ensure unsafe traps are only enabled

+ // during testing.

virtual bool EnableUnsafeTraps() = 0;

protected:

« sandbox/linux/bpf_dsl/policy_compiler.cc ('K') | « sandbox/linux/bpf_dsl/policy_compiler.cc ('k') | no next file » | no next file with comments »