Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: sky/tests/layout/document-elementFromPoint.sky

Issue 945693002: Move hit testing out of RenderLayer into RenderBox. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: add to test case Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/layout/document-elementFromPoint.sky
diff --git a/sky/tests/layout/document-elementFromPoint.sky b/sky/tests/layout/document-elementFromPoint.sky
index 461b782d0979c9e4cc34980d8c26fe6fa88261fd..94257d81cd6491aa7c4908810d9e4c94bd5fe675 100644
--- a/sky/tests/layout/document-elementFromPoint.sky
+++ b/sky/tests/layout/document-elementFromPoint.sky
@@ -5,10 +5,15 @@ bar { width: 100px; height: 100px; background: purple; }
parent { display: paragraph; }
child { background: salmon; }
canvas { height: 50px; background-color: pink; }
+inline-block { display: inline-block; width: 50px; height: 50px; background: green; }
+grand-child { width: 50px; height: 50px; transform: translate3d(100px, 0, 0); background: papayawhip; }
</style>
<foo /><bar />
<parent>
<child>Foo bar</child>
+ <inline-block>
+ <grand-child />
+ </inline-block>
</parent>
<canvas />
<script>
@@ -52,9 +57,14 @@ void main() {
});
test("should hit test transformed child", () {
+ document.querySelector('parent').style["display"] = "block";
document.querySelector('child').style["transform"] = "translate3d(100px, 0, 0)";
expect(document.elementFromPoint(50, 210).tagName, equals('parent'));
expect(document.elementFromPoint(150, 210).tagName, equals('child'));
+ expect(document.elementFromPoint(25, 240).tagName, equals('inline-block'));
+ // TODO(ojan): This is incorrect. It should hit grand-child.
+ // This broke sometime before 4153b8a515d54275934d4244aaf2d5a7a8fe3333.
+ expect(document.elementFromPoint(150, 240).tagName, equals('sky'));
});
test("should hit test canvas", () {
« no previous file with comments | « sky/engine/core/rendering/RenderView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698