sky/engine/core/rendering/RenderView.cpp - Issue 945693002: Move hit testing out of RenderLayer into RenderBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 945693002: Move hit testing out of RenderLayer into RenderBox. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: add to test case Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderView.cpp

diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp

index 6d15d205ffec237c2211dbd76a7bff4c928ae816..cfb881439566d1aa0765e0a8eec28b6ab6056a49 100644

--- a/sky/engine/core/rendering/RenderView.cpp

+++ b/sky/engine/core/rendering/RenderView.cpp

@@ -91,7 +91,7 @@ bool RenderView::hitTest(const HitTestRequest& request, const HitTestLocation& l

if (!request.ignoreClipping())

hitTestArea.intersect(frame()->view()->visibleContentRect());

- bool insideLayer = layer()->hitTestLayer(layer(), 0, request, result, hitTestArea, location);

+ bool insideLayer = hitTestLayer(layer(), 0, request, result, hitTestArea, location);

if (!insideLayer) {

// TODO(ojan): Is this code needed for Sky?