Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2560)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 945413005: Add browser test for V8 code caching for ServiceWorker scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated kinuko's comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 138c11555d8201b11f538bbd2b18570c6665640d..65189d19e1d6e50a95118a1ff7be51dca9ef65b9 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -278,18 +278,6 @@ void KillEmbeddedWorkerProcess(int process_id, ResultCode code) {
render_process_host->ReceivedBadMessage();
}
-void DidSetCachedMetadata(int64 callback_id, int result) {
- TRACE_EVENT_ASYNC_END1("ServiceWorker",
- "ServiceWorkerVersion::OnSetCachedMetadata",
- callback_id, "result", result);
-}
-
-void DidClearCachedMetadata(int64 callback_id, int result) {
- TRACE_EVENT_ASYNC_END1("ServiceWorker",
- "ServiceWorkerVersion::OnClearCachedMetadata",
- callback_id, "result", result);
-}
-
} // namespace
ServiceWorkerVersion::ServiceWorkerVersion(
@@ -1264,7 +1252,16 @@ void ServiceWorkerVersion::OnSetCachedMetadata(const GURL& url,
"ServiceWorkerVersion::OnSetCachedMetadata",
callback_id, "URL", url.spec());
script_cache_map_.WriteMetadata(
- url, data, base::Bind(&DidSetCachedMetadata, callback_id));
+ url, data, base::Bind(&ServiceWorkerVersion::OnSetCachedMetadataFinished,
+ weak_factory_.GetWeakPtr(), callback_id));
+}
+
+void ServiceWorkerVersion::OnSetCachedMetadataFinished(int64 callback_id,
+ int result) {
+ TRACE_EVENT_ASYNC_END1("ServiceWorker",
+ "ServiceWorkerVersion::OnSetCachedMetadata",
+ callback_id, "result", result);
+ FOR_EACH_OBSERVER(Listener, listeners_, OnCachedMetadataUpdated(this));
}
void ServiceWorkerVersion::OnClearCachedMetadata(const GURL& url) {
@@ -1273,7 +1270,16 @@ void ServiceWorkerVersion::OnClearCachedMetadata(const GURL& url) {
"ServiceWorkerVersion::OnClearCachedMetadata",
callback_id, "URL", url.spec());
script_cache_map_.ClearMetadata(
- url, base::Bind(&DidClearCachedMetadata, callback_id));
+ url, base::Bind(&ServiceWorkerVersion::OnClearCachedMetadataFinished,
+ weak_factory_.GetWeakPtr(), callback_id));
+}
+
+void ServiceWorkerVersion::OnClearCachedMetadataFinished(int64 callback_id,
+ int result) {
+ TRACE_EVENT_ASYNC_END1("ServiceWorker",
+ "ServiceWorkerVersion::OnClearCachedMetadata",
+ callback_id, "result", result);
+ FOR_EACH_OBSERVER(Listener, listeners_, OnCachedMetadataUpdated(this));
}
void ServiceWorkerVersion::OnPostMessageToDocument(
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698