content/browser/service_worker/service_worker_version.h - Issue 945413005: Add browser test for V8 code caching for ServiceWorker scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 945413005: Add browser test for V8 code caching for ServiceWorker scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated kinuko's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index b39c9c5542df79e066d63ec06d3c5ef2e45fff7c..7308e9661546393f1975710aa6602af8db064540 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -109,6 +109,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

const GURL& source_url) {}

// Fires when a version transitions from having a controllee to not.

virtual void OnNoControllees(ServiceWorkerVersion* version) {}

+ virtual void OnCachedMetadataUpdated(ServiceWorkerVersion* version) {}

protected:

virtual ~Listener() {}

@@ -379,7 +380,9 @@ class CONTENT_EXPORT ServiceWorkerVersion

const ServiceWorkerClientInfo& client_info);

void OnSetCachedMetadata(const GURL& url, const std::vector<char>& data);

+ void OnSetCachedMetadataFinished(int64 callback_id, int result);

void OnClearCachedMetadata(const GURL& url);

+ void OnClearCachedMetadataFinished(int64 callback_id, int result);

void OnPostMessageToDocument(int client_id,

const base::string16& message,