Add browser test for V8 code caching for ServiceWorker scripts.

Add browser test for V8 code caching for ServiceWorker scripts.

BUG=449895
TEST=content_browsertests --gtest_filter=ServiceWorkerVersionBrowserV8CacheTest.*

Committed: https://crrev.com/57b85942d40ea1e9fe0d933434392bc67b23e8a3
Cr-Commit-Position: refs/heads/master@{#317762}

[horo, 2015-02-24 01:35:26]

horo@chromium.org changed reviewers:
+ kinuko@chromium.org

[horo, 2015-02-24 01:35:26]

kinuko@
Could you please review this?

[wfa511com, 2015-02-24 01:42:15]

بتاريخ Feb 24, 2015 4:35 AM، كتبها <horo@chromium.org>:

> Reviewers: kinuko,
>
> Message:
> kinuko@
> Could you please review this?
>
> Description:
> Add browser test for V8 code caching for ServiceWorker scripts.
>
>
> BUG=449895
> TEST=content_browsertests
> --gtest_filter=ServiceWorkerVersionBrowserV8CacheTest.*
>
> Please review this at https://codereview.chromium.org/945413005/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+104, -24 lines):
>   M content/browser/service_worker/service_worker_browsertest.cc
>   M content/browser/service_worker/service_worker_version.h
>   M content/browser/service_worker/service_worker_version.cc
>   M content/public/common/content_switches.h
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[kinuko, 2015-02-24 05:21:39]

lgtm

https://codereview.chromium.org/945413005/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/945413005/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:1069: typedef
ServiceWorkerVersionBrowserV8CacheTest self;
nit: typedef -> using in new code?

https://codereview.chromium.org/945413005/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:1103:
cached_metadata_run_loop.Run();
nit: please insert an empty line here, and add a comment like 'this run loop
should finish when OnCachedMetadataUpdated() is called' on line 1102

[horo, 2015-02-24 06:15:52]

horo@chromium.org changed reviewers:
- wfa511com@gmail.com

[horo, 2015-02-24 06:15:53]

Thank you!

https://codereview.chromium.org/945413005/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/945413005/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:1069: typedef
ServiceWorkerVersionBrowserV8CacheTest self;
On 2015/02/24 05:21:39, kinuko wrote:
> nit: typedef -> using in new code?

Done.

https://codereview.chromium.org/945413005/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:1103:
cached_metadata_run_loop.Run();
On 2015/02/24 05:21:39, kinuko wrote:
> nit: please insert an empty line here, and add a comment like 'this run loop
> should finish when OnCachedMetadataUpdated() is called' on line 1102

Done.

[horo, 2015-02-24 06:51:25]

horo@chromium.org changed reviewers:
+ nasko@chromium.org

[horo, 2015-02-24 06:51:25]

nasko@
Could you please review content/public/common/content_switches.h?

[nasko, 2015-02-24 06:53:51]

LGTM

[horo, 2015-02-24 06:55:07]

The CQ bit was checked by horo@chromium.org

[horo, 2015-02-24 06:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/945413005/#ps20001 (title:
"incorporated kinuko's comment")

[commit-bot: I haz the power, 2015-02-24 06:56:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945413005/20001

[commit-bot: I haz the power, 2015-02-24 07:16:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-24 07:17:12]

Patchset 2 (id:??) landed as
https://crrev.com/57b85942d40ea1e9fe0d933434392bc67b23e8a3
Cr-Commit-Position: refs/heads/master@{#317762}