Adding support for diagonal scrolling to telemetry.

content/renderer/gpu/gpu_benchmarking_extension.cc

Index: content/renderer/gpu/gpu_benchmarking_extension.cc
diff --git a/content/renderer/gpu/gpu_benchmarking_extension.cc b/content/renderer/gpu/gpu_benchmarking_extension.cc
index 68221886255898ee802d9565de7841ad6f73cf27..7b81b68e57d5db65dc8d777d0355f4c896f284b6 100644
--- a/content/renderer/gpu/gpu_benchmarking_extension.cc
+++ b/content/renderer/gpu/gpu_benchmarking_extension.cc
@@ -366,6 +366,22 @@ bool BeginSmoothScroll(v8::Isolate* isolate,
     distance.set_x(-distance_length);
   else if (direction == "left")
     distance.set_x(distance_length);
+  else if (direction == "upleft") {
+    distance.set_y(distance_length);
+    distance.set_x(distance_length);
+  }
+  else if (direction == "upright") {

[jdduke (slow), 2015/02/26 01:05:35]

Nit: else should start on the same line as the preceding brace ("git cl format"
should take care of that).

I suppose you could also do something like:

if (direction.find("up") != string::npos)
  direction.set_y(-distance_length);
else if (direction.find("down") != string::npos)
  direction.set_y(distance_length);

and similarly for right/left, then return false if distance is null. But maybe
it's better to be explicit here. 

[cblume, 2015/02/26 20:22:00]

Oh, thank you. I've fixed this locally and will upload it along with the change
to the tests once we decide how best to handle them.

I went with the non-.find() option but am open to changing that. My thought was
if someone put "up down" it would mimic "down". But since "up down" doesn't make
sense anyway, maybe I shouldn't care about these odd cases.

+    distance.set_y(distance_length);
+    distance.set_x(-distance_length);
+  }
+  else if (direction == "downleft") {
+    distance.set_y(-distance_length);
+    distance.set_x(distance_length);
+  }
+  else if (direction == "downright") {
+    distance.set_y(-distance_length);
+    distance.set_x(-distance_length);
+  }
   else {
     return false;
   }