Adding support for diagonal scrolling to telemetry.

content/renderer/gpu/gpu_benchmarking_extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/gpu_benchmarking_extension.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/files/file_path.h"
@@ skipping 348 matching lines @@
   int distance_length = pixels_to_scroll * page_scale_factor;
   gfx::Vector2d distance;
   if (direction == "down")
     distance.set_y(-distance_length);
   else if (direction == "up")
     distance.set_y(distance_length);
   else if (direction == "right")
     distance.set_x(-distance_length);
   else if (direction == "left")
     distance.set_x(distance_length);
+  else if (direction == "upleft") {
+    distance.set_y(distance_length);
+    distance.set_x(distance_length);
+  }
+  else if (direction == "upright") {

[jdduke (slow), 2015/02/26 01:05:35]

Nit: else should start on the same line as the preceding brace ("git cl format"
should take care of that).

I suppose you could also do something like:

if (direction.find("up") != string::npos)
  direction.set_y(-distance_length);
else if (direction.find("down") != string::npos)
  direction.set_y(distance_length);

and similarly for right/left, then return false if distance is null. But maybe
it's better to be explicit here. 

[cblume, 2015/02/26 20:22:00]

Oh, thank you. I've fixed this locally and will upload it along with the change
to the tests once we decide how best to handle them.

I went with the non-.find() option but am open to changing that. My thought was
if someone put "up down" it would mimic "down". But since "up down" doesn't make
sense anyway, maybe I shouldn't care about these odd cases.

+    distance.set_y(distance_length);
+    distance.set_x(-distance_length);
+  }
+  else if (direction == "downleft") {
+    distance.set_y(-distance_length);
+    distance.set_x(distance_length);
+  }
+  else if (direction == "downright") {
+    distance.set_y(-distance_length);
+    distance.set_x(-distance_length);
+  }
   else {
     return false;
   }
   gesture_params->distances.push_back(distance);
 
   // TODO(nduca): If the render_view_impl is destroyed while the gesture is in
   // progress, we will leak the callback and context. This needs to be fixed,
   // somehow.
   context.render_view_impl()->QueueSyntheticGesture(
       gesture_params.Pass(),
@@ skipping 428 matching lines @@
 
   return context.compositor()->SendMessageToMicroBenchmark(id, value.Pass());
 }
 
 bool GpuBenchmarking::HasGpuProcess() {
     GpuChannelHost* gpu_channel = RenderThreadImpl::current()->GetGpuChannel();
     return !!gpu_channel;
 }
 
 }  // namespace content