Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 945303002: DevTools: do not mute the protocol channel while reattaching. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
Reviewers:
dgozman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not mute the protocol channel while reattaching. Otherwise sync notifications are not going through. BUG=460697 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pfeldman
5 years, 10 months ago (2015-02-21 21:37:40 UTC) #2
dgozman
lgtm
5 years, 10 months ago (2015-02-24 09:28:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945303002/1
5 years, 10 months ago (2015-02-24 09:30:26 UTC) #5
yurys
Can we test this?
5 years, 10 months ago (2015-02-24 10:15:59 UTC) #6
pfeldman
On 2015/02/24 10:15:59, yurys wrote: > Can we test this? Yes, we can! In a ...
5 years, 10 months ago (2015-02-24 10:30:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190745
5 years, 10 months ago (2015-02-24 12:05:26 UTC) #8
sergeyv
5 years, 10 months ago (2015-02-25 10:38:40 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/958573002/ by sergeyv@chromium.org.

The reason for reverting is: DevToolsSanityTest.TestReattachAfterCrash is flaky
on OSX 10.6 after this patch.

Powered by Google App Engine
This is Rietveld 408576698