Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 945303002: DevTools: do not mute the protocol channel while reattaching. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index 29d8936cef850d876cd3b5d52dcd64a1793ab4a8..30856a69139a0004cea1cac5ca0c6f4835a09810 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -240,9 +240,10 @@ void WebDevToolsAgentImpl::attach(const WebString& hostId)
if (m_attached)
return;
+ // Set the attached bit first so that sync notifications were delivered.
+ m_attached = true;
inspectorController()->connectFrontend(hostId, this);
Platform::current()->currentThread()->addTaskObserver(this);
- m_attached = true;
}
void WebDevToolsAgentImpl::reattach(const WebString& hostId, const WebString& savedState)
@@ -250,9 +251,10 @@ void WebDevToolsAgentImpl::reattach(const WebString& hostId, const WebString& sa
if (m_attached)
return;
+ // Set the attached bit first so that sync notifications were delivered.
+ m_attached = true;
inspectorController()->reuseFrontend(hostId, this, savedState);
Platform::current()->currentThread()->addTaskObserver(this);
- m_attached = true;
}
void WebDevToolsAgentImpl::detach()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698