Issue 945143006: PRESUBMIT: UMA histogram check, rewind histograms.xml file between unmatched_histograms searches

Issue 945143006: PRESUBMIT: UMA histogram check, rewind histograms.xml file between unmatched_histograms searches (Closed)

Created:
5 years, 10 months ago by mcasas

Modified:
5 years, 10 months ago

Reviewers:
Alexei Svitkine (slow), Roger Tawa OOO till Jul 10th, Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

PRESUBMIT: UMA histogram check, rewind histograms.xml file between unmatched_histograms searches BUG=434420, 445265 Committed: https://crrev.com/39c1b8b7c3b3b7421d24f0451f787970e9b41e93 Cr-Commit-Position: refs/heads/master@{#318049}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 12 (4 generated)

Roger Tawa OOO till Jul 10th

lgtm Thanks Miguel, fixed warning with my problematic CLhttps://codereview.chromium.org/914363003/

5 years, 10 months ago (2015-02-24 19:02:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945143006/1

5 years, 10 months ago (2015-02-25 15:31:09 UTC) #10

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 15:34:32 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/39c1b8b7c3b3b7421d24f0451f787970e9b41e93
Cr-Commit-Position: refs/heads/master@{#318049}