Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 945143006: PRESUBMIT: UMA histogram check, rewind histograms.xml file between unmatched_histograms searches (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5507aa1363f369b06bac20bfb6a0c3669adcd5e9..a84f3f90d7029a8c43c78c50d7ff1b69ce04a73c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -406,6 +406,7 @@ def _CheckUmaHistogramChanges(input_api, output_api):
if unmatched_histograms:
with open('tools/metrics/histograms/histograms.xml') as histograms_xml:
for histogram_name, f, line_num in unmatched_histograms:
+ histograms_xml.seek(0)
histogram_name_found = False
for line in histograms_xml:
histogram_name_found = _FindHistogramNameInLine(histogram_name, line)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698