base::Time multiplicative operator overloading

base::Time multiplicative operator overloading

Committed: https://crrev.com/6e3b48b35f7a96246bcc0bb9e2ec846053349d99
Cr-Commit-Position: refs/heads/master@{#317653}

[michaeln, 2015-02-20 23:58:09]

michaeln@chromium.org changed reviewers:
+ rvargas@chromium.org

[michaeln, 2015-02-20 23:58:56]

ptal

[rvargas (doing something else), 2015-02-21 01:17:45]

LGTM with nits.

https://codereview.chromium.org/945143002/diff/1/base/time/time.h
File base/time/time.h (right):

https://codereview.chromium.org/945143002/diff/1/base/time/time.h#newcode162
base/time/time.h:162: // operations with other types.
nit: Thanks. The comment was certainly confusing. I think we can remove the note
at this point (not telling me much)

https://codereview.chromium.org/945143002/diff/1/base/time/time.h#newcode213
base/time/time.h:213: template<typename T>
We can remove this...

https://codereview.chromium.org/945143002/diff/1/base/time/time.h#newcode228
base/time/time.h:228: return TimeDelta(a * td.delta_);
with a 
return td * a;

[michaeln, 2015-02-23 20:02:18]

https://codereview.chromium.org/945143002/diff/1/base/time/time.h
File base/time/time.h (right):

https://codereview.chromium.org/945143002/diff/1/base/time/time.h#newcode162
base/time/time.h:162: // operations with other types.
On 2015/02/21 01:17:45, rvargas wrote:
> nit: Thanks. The comment was certainly confusing. I think we can remove the
note
> at this point (not telling me much)

Done

https://codereview.chromium.org/945143002/diff/1/base/time/time.h#newcode228
base/time/time.h:228: return TimeDelta(a * td.delta_);
On 2015/02/21 01:17:45, rvargas wrote:
> with a 
> return td * a;

Done (thnx)

[michaeln, 2015-02-23 20:02:23]

The CQ bit was checked by michaeln@chromium.org

[michaeln, 2015-02-23 20:02:24]

The patchset sent to the CQ was uploaded after l-g-t-m from rvargas@chromium.org
Link to the patchset: https://codereview.chromium.org/945143002/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-02-23 20:03:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945143002/20001

[commit-bot: I haz the power, 2015-02-23 21:22:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-23 21:25:40]

Patchset 2 (id:??) landed as
https://crrev.com/6e3b48b35f7a96246bcc0bb9e2ec846053349d99
Cr-Commit-Position: refs/heads/master@{#317653}