base::Time multiplicative operator overloading

base/time/time.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Time represents an absolute point in coordinated universal time (UTC),
 // internally represented as microseconds (s/1,000,000) since the Windows epoch
 // (1601-01-01 00:00:00 UTC) (See http://crbug.com/14734).  System-dependent
 // clock interface routines are defined in time_PLATFORM.cc.
 //
 // TimeDelta represents a duration of time, internally represented in
@@ skipping 140 matching lines @@
     return *this;
   }
   TimeDelta& operator-=(TimeDelta other) {
     delta_ -= other.delta_;
     return *this;
   }
   TimeDelta operator-() const {
     return TimeDelta(-delta_);
   }
 
-  // Computations with ints, note that we only allow multiplicative operations
-  // with ints, and additive operations with other deltas.
-  TimeDelta operator*(int64 a) const {
+  // Computations with numeric types, note that we only allow multiplicative
+  // operations with other types.

[rvargas (doing something else), 2015/02/21 01:17:45]

nit: Thanks. The comment was certainly confusing. I think we can remove the note
at this point (not telling me much)

[michaeln, 2015/02/23 20:02:17]

Done

+  template<typename T>
+  TimeDelta operator*(T a) const {
     return TimeDelta(delta_ * a);
   }
-  TimeDelta operator/(int64 a) const {
+  template<typename T>
+  TimeDelta operator/(T a) const {
     return TimeDelta(delta_ / a);
   }
-  TimeDelta& operator*=(int64 a) {
+  template<typename T>
+  TimeDelta& operator*=(T a) {
     delta_ *= a;
     return *this;
   }
-  TimeDelta& operator/=(int64 a) {
+  template<typename T>
+  TimeDelta& operator/=(T a) {
     delta_ /= a;
     return *this;
   }
+
   int64 operator/(TimeDelta a) const {
     return delta_ / a.delta_;
   }
 
-  // Multiplicative computations with floats.
-  TimeDelta multiply_by(double a) const {
-    return TimeDelta(delta_ * a);
-  }
-  TimeDelta divide_by(double a) const {
-    return TimeDelta(delta_ / a);
-  }
-
   // Defined below because it depends on the definition of the other classes.
   Time operator+(Time t) const;
   TimeTicks operator+(TimeTicks t) const;
 
   // Comparison operators.
   bool operator==(TimeDelta other) const {
     return delta_ == other.delta_;
   }
   bool operator!=(TimeDelta other) const {
     return delta_ != other.delta_;
   }
   bool operator<(TimeDelta other) const {
     return delta_ < other.delta_;
   }
   bool operator<=(TimeDelta other) const {
     return delta_ <= other.delta_;
   }
   bool operator>(TimeDelta other) const {
     return delta_ > other.delta_;
   }
   bool operator>=(TimeDelta other) const {
     return delta_ >= other.delta_;
   }
 
  private:
   friend class Time;
   friend class TimeTicks;
-  friend TimeDelta operator*(int64 a, TimeDelta td);
+  template<typename T>

[rvargas (doing something else), 2015/02/21 01:17:44]

We can remove this...

+  friend TimeDelta operator*(T a, TimeDelta td);
 
   // Constructs a delta given the duration in microseconds. This is private
   // to avoid confusion by callers with an integer constructor. Use
   // FromSeconds, FromMilliseconds, etc. instead.
   explicit TimeDelta(int64 delta_us) : delta_(delta_us) {
   }
 
   // Delta in microseconds.
   int64 delta_;
 };
 
-inline TimeDelta operator*(int64 a, TimeDelta td) {
+template<typename T>
+inline TimeDelta operator*(T a, TimeDelta td) {
   return TimeDelta(a * td.delta_);

[rvargas (doing something else), 2015/02/21 01:17:45]

with a 
return td * a;

[michaeln, 2015/02/23 20:02:18]

Done (thnx)

 }
 
 // For logging use only.
 BASE_EXPORT std::ostream& operator<<(std::ostream& os, TimeDelta time_delta);
 
 // Time -----------------------------------------------------------------------
 
 // Represents a wall clock time in UTC.
 class BASE_EXPORT Time {
  public:
@@ skipping 522 matching lines @@
 inline TimeTicks TimeDelta::operator+(TimeTicks t) const {
   return TimeTicks(t.ticks_ + delta_);
 }
 
 // For logging use only.
 BASE_EXPORT std::ostream& operator<<(std::ostream& os, TimeTicks time_ticks);
 
 }  // namespace base
 
 #endif  // BASE_TIME_TIME_H_