Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 944923005: Use easier method to determine allocation space when serializing. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use easier method to determine allocation space when serializing. R=hpayer@chromium.org Committed: https://crrev.com/30a6e46a395ef14f367507d4778bf6acfa5ea510 Cr-Commit-Position: refs/heads/master@{#26851}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M src/serialize.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/serialize.cc View 1 2 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 10 months ago (2015-02-25 10:48:14 UTC) #1
Hannes Payer (out of office)
LGTM, one nit. https://codereview.chromium.org/944923005/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/944923005/diff/1/src/serialize.cc#newcode1892 src/serialize.cc:1892: AllocationSpace space = MemoryChunk::FromAddress(addr)->owner()->identity(); Please use ...
5 years, 10 months ago (2015-02-25 13:19:34 UTC) #2
Yang
On 2015/02/25 13:19:34, Hannes Payer wrote: > LGTM, one nit. > > https://codereview.chromium.org/944923005/diff/1/src/serialize.cc > File ...
5 years, 10 months ago (2015-02-25 13:33:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944923005/20001
5 years, 10 months ago (2015-02-25 13:34:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 14:05:43 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 14:05:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30a6e46a395ef14f367507d4778bf6acfa5ea510
Cr-Commit-Position: refs/heads/master@{#26851}

Powered by Google App Engine
This is Rietveld 408576698