Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: net/quic/quic_connection_logger_unittest.cc

Issue 944883003: QUIC - Cache the connection type and connection description. Make the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed const char* const as return value to fix ios_rel_device_ninja_ng compile error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection_logger_unittest.cc
diff --git a/net/quic/quic_connection_logger_unittest.cc b/net/quic/quic_connection_logger_unittest.cc
index 739267279779e24dd68f678b20b33d614c320a7d..fe9bfbe3013a7c9c07b3015f270c8cb08cc79de9 100644
--- a/net/quic/quic_connection_logger_unittest.cc
+++ b/net/quic/quic_connection_logger_unittest.cc
@@ -4,6 +4,7 @@
#include "net/quic/quic_connection_logger.h"
+#include "net/quic/network_connection.h"
#include "net/quic/quic_protocol.h"
#include "net/quic/test_tools/quic_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -21,10 +22,13 @@ class QuicConnectionLoggerPeer {
class QuicConnectionLoggerTest : public ::testing::Test {
protected:
QuicConnectionLoggerTest()
- : session_(new MockConnection(false)), logger_(&session_, net_log_) {}
+ : session_(new MockConnection(false)),
+ network_connection_(),
+ logger_(&session_, network_connection_.GetDescription(), net_log_) {}
Ryan Hamilton 2015/02/23 20:42:19 same comment here about just using "some_descripti
ramant (doing other things) 2015/02/23 21:05:30 Done.
BoundNetLog net_log_;
MockSession session_;
+ NetworkConnection network_connection_;
QuicConnectionLogger logger_;
};

Powered by Google App Engine
This is Rietveld 408576698