QUIC - Cache the connection type and connection description. Make the

net/quic/quic_client_session_test.cc

Index: net/quic/quic_client_session_test.cc
diff --git a/net/quic/quic_client_session_test.cc b/net/quic/quic_client_session_test.cc
index ee7ee0cb637a4318bdec6cbd576c2bec8ce99182..04e686020990bb8367b9e321d0aa249587fbbad9 100644
--- a/net/quic/quic_client_session_test.cc
+++ b/net/quic/quic_client_session_test.cc
@@ -20,6 +20,7 @@
 #include "net/quic/crypto/quic_decrypter.h"
 #include "net/quic/crypto/quic_encrypter.h"
 #include "net/quic/crypto/quic_server_info.h"
+#include "net/quic/network_connection.h"
 #include "net/quic/test_tools/crypto_test_utils.h"
 #include "net/quic/test_tools/quic_client_session_peer.h"
 #include "net/quic/test_tools/quic_test_utils.h"
@@ -43,9 +44,14 @@ class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
   QuicClientSessionTest()
       : connection_(
             new PacketSavingConnection(false, SupportedVersions(GetParam()))),
-        session_(connection_, GetSocket().Pass(), nullptr,
+        network_connection_(),
+        session_(connection_,
+                 GetSocket().Pass(),
+                 nullptr,
                  &transport_security_state_,
-                 make_scoped_ptr((QuicServerInfo*)nullptr), DefaultQuicConfig(),
+                 make_scoped_ptr((QuicServerInfo*)nullptr),
+                 DefaultQuicConfig(),
+                 network_connection_.GetDescription(),

[Ryan Hamilton, 2015/02/23 20:42:19]

I think you can just pass in any string you want here. No need to create an
actual NetworkConnection.

[ramant (doing other things), 2015/02/23 21:05:29]

Done.

                  base::MessageLoop::current()->message_loop_proxy().get(),
                  &net_log_) {
     session_.InitializeSession(QuicServerId(kServerHostname, kServerPort,
@@ -78,6 +84,7 @@ class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
   MockClientSocketFactory socket_factory_;
   StaticSocketDataProvider socket_data_;
   TransportSecurityState transport_security_state_;
+  NetworkConnection network_connection_;
   QuicClientSession session_;
   MockClock clock_;
   MockRandom random_;