Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: net/quic/quic_connection_logger_unittest.cc

Issue 944883003: QUIC - Cache the connection type and connection description. Make the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move description caching into a distinct class Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection_logger_unittest.cc
diff --git a/net/quic/quic_connection_logger_unittest.cc b/net/quic/quic_connection_logger_unittest.cc
index 739267279779e24dd68f678b20b33d614c320a7d..69b2c5b180f7737d0d1cc019e87ac194f375b1d7 100644
--- a/net/quic/quic_connection_logger_unittest.cc
+++ b/net/quic/quic_connection_logger_unittest.cc
@@ -16,16 +16,25 @@ class QuicConnectionLoggerPeer {
static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) {
return logger.num_truncated_acks_sent_;
}
+ static const char* connection_description(
+ const QuicConnectionLogger& logger) {
+ return logger.connection_description_;
+ }
};
class QuicConnectionLoggerTest : public ::testing::Test {
protected:
QuicConnectionLoggerTest()
- : session_(new MockConnection(false)), logger_(&session_, net_log_) {}
+ : session_(new MockConnection(false)),
+ logger_(&session_, &network_connection_, net_log_) {
+ EXPECT_NE(nullptr,
+ QuicConnectionLoggerPeer::connection_description(logger_));
+ }
BoundNetLog net_log_;
MockSession session_;
QuicConnectionLogger logger_;
+ NetworkConnection network_connection_;
};
TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) {

Powered by Google App Engine
This is Rietveld 408576698