Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Side by Side Diff: net/quic/quic_connection_logger_unittest.cc

Issue 944883003: QUIC - Cache the connection type and connection description. Make the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move description caching into a distinct class Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_connection_logger.h" 5 #include "net/quic/quic_connection_logger.h"
6 6
7 #include "net/quic/quic_protocol.h" 7 #include "net/quic/quic_protocol.h"
8 #include "net/quic/test_tools/quic_test_utils.h" 8 #include "net/quic/test_tools/quic_test_utils.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace net { 11 namespace net {
12 namespace test { 12 namespace test {
13 13
14 class QuicConnectionLoggerPeer { 14 class QuicConnectionLoggerPeer {
15 public: 15 public:
16 static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) { 16 static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) {
17 return logger.num_truncated_acks_sent_; 17 return logger.num_truncated_acks_sent_;
18 } 18 }
19 static const char* connection_description(
20 const QuicConnectionLogger& logger) {
21 return logger.connection_description_;
22 }
19 }; 23 };
20 24
21 class QuicConnectionLoggerTest : public ::testing::Test { 25 class QuicConnectionLoggerTest : public ::testing::Test {
22 protected: 26 protected:
23 QuicConnectionLoggerTest() 27 QuicConnectionLoggerTest()
24 : session_(new MockConnection(false)), logger_(&session_, net_log_) {} 28 : session_(new MockConnection(false)),
29 logger_(&session_, &network_connection_, net_log_) {
30 EXPECT_NE(nullptr,
31 QuicConnectionLoggerPeer::connection_description(logger_));
32 }
25 33
26 BoundNetLog net_log_; 34 BoundNetLog net_log_;
27 MockSession session_; 35 MockSession session_;
28 QuicConnectionLogger logger_; 36 QuicConnectionLogger logger_;
37 NetworkConnection network_connection_;
29 }; 38 };
30 39
31 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) { 40 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) {
32 QuicAckFrame frame; 41 QuicAckFrame frame;
33 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 42 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
34 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 43 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
35 44
36 for (QuicPacketSequenceNumber i = 0; i < 256; ++i) { 45 for (QuicPacketSequenceNumber i = 0; i < 256; ++i) {
37 frame.missing_packets.insert(i); 46 frame.missing_packets.insert(i);
38 } 47 }
39 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 48 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
40 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 49 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
41 } 50 }
42 51
43 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) { 52 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) {
44 QuicAckFrame frame; 53 QuicAckFrame frame;
45 for (QuicPacketSequenceNumber i = 0; i < 512; i += 2) { 54 for (QuicPacketSequenceNumber i = 0; i < 512; i += 2) {
46 frame.missing_packets.insert(i); 55 frame.missing_packets.insert(i);
47 } 56 }
48 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 57 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
49 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 58 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
50 } 59 }
51 60
52 } // namespace test 61 } // namespace test
53 } // namespace net 62 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698